-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign and allow people to upload in the multiple locations #31
Conversation
Add initial l10n support
Proposed Polish translation file
Thank you for this app. It works great. Let me propose one more Polish translation file.
Added Polish translation (thanks to @mzary)
Added Polish translation (thanks to @mzary)
translation to Czech
Added Czech Translation (thanks to @CHazz)
Corrected translation (transfers, uploading)
change two bad translations (transfers and uploading)
Update French translation (thanks @Larsene)
Update French translation (thanks @Larsene)
@e-alfred Everything is fixed like you asked :) I can try to free some time so we can add a db (to save locations used by each user + save params like default locations if you are on !) |
@NastuzziSamy Thanks for fixing up everything, I will merge it as soon as possible! |
I found a few problems regarding support for Nextcloud 14 and upwards, please see the review comments. |
@e-alfred Which comment ? I already fixed them ^^ |
@NastuzziSamy The \OC_Response::setStatus calls which were deprecated in Nextcoud 14 and up. |
I would love to merge your PR if you could fix those deprecated calls so it can be used with Nextcloud 14 and 15. |
@e-alfred, sorry for being so late. I commit this week end. Feel free to do whatever you want if I don't do it. Really sorry |
@e-alfred I am confused, did you merged this PR ? ^^ |
No, I didn't merge it, I just fixed some deprecated calls. At the moment there are UI issues with this PR on Nextcloud 14 and up which have to be fixed. |
@NastuzziSamy Any news on your rework? I still like the idea but it still needs some polish. One thing that would be great to have is a folder navigation option when clicking on the "+" button to make it easier for users to select and create folders where files should be uploaded. |
This is simply taking to long. Is there any way i can move the PR to a fork of the project ? I badly need this feature too :-) |
@hezten If you want to finish this feature it would be awesome! To restart work on this PR you could just fork the flowupload repository of @NastuzziSamy from here: https://github.com/NastuzziSamy/flowupload Please make a new PR as soon as you finish your work so it can become part of the official release of Flowupload! |
Has this become an official release by any chance? |
Because so many things changed in master i made another PR with the Changes from NastuzziSamy but in the latest flowupload version. New PR: #73 |
@JonathanTreffler Thanks for your help! Maybe we can close this PR if your new PR is good enough for merging? |
Yes. That's probably a good idea |
Hey guys, just saw what you did. Thanks for taking your time finishing what I started, too busy this last years :/ Closing this :) |
Actually, is this PR useless or I can rework on it ? |
Do not hesitate to personaly ping/email me if needed |
I am currently working on a implementation of this feature so this PR is probably not necessary anymore. |
Can you then at least co-author me @JonathanTreffler in your commits ? I saw your PRS, where you are referencing me but not giving me credit 😊 |
Ok, how should i do that ? |
PR #73 is fixing this feature finally, thanks for your help still! |
Hey !
I worked on it, for a first time allow people to choose and to send in the same time on multiple locations.
I hope you will enjoy what i tried to do and I am working to manage file transfers via database for a further version