Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign and allow people to upload in the multiple locations #31

Closed
wants to merge 36 commits into from

Conversation

NastuzziSamy
Copy link

Hey !

I worked on it, for a first time allow people to choose and to send in the same time on multiple locations.

I hope you will enjoy what i tried to do and I am working to manage file transfers via database for a further version

NastuzziSamy and others added 30 commits February 5, 2018 14:28
Proposed Polish translation file
Thank you for this app. It works great.
Let me propose one more Polish translation file.
Added Polish translation (thanks to @mzary)
Added Polish translation (thanks to @mzary)
translation to Czech
Added Czech Translation (thanks to @CHazz)
Corrected translation (transfers, uploading)
change two bad translations (transfers and uploading)
Update French translation (thanks @Larsene)
Update French translation (thanks @Larsene)
Change templates
Add location managments
@NastuzziSamy
Copy link
Author

@e-alfred Everything is fixed like you asked :)

I can try to free some time so we can add a db (to save locations used by each user + save params like default locations if you are on !)

@e-alfred
Copy link
Owner

@NastuzziSamy Thanks for fixing up everything, I will merge it as soon as possible!

@e-alfred
Copy link
Owner

I found a few problems regarding support for Nextcloud 14 and upwards, please see the review comments.

@NastuzziSamy
Copy link
Author

@e-alfred Which comment ? I already fixed them ^^

@e-alfred
Copy link
Owner

@NastuzziSamy The \OC_Response::setStatus calls which were deprecated in Nextcoud 14 and up.

@e-alfred
Copy link
Owner

I would love to merge your PR if you could fix those deprecated calls so it can be used with Nextcloud 14 and 15.

@NastuzziSamy
Copy link
Author

@e-alfred, sorry for being so late. I commit this week end. Feel free to do whatever you want if I don't do it. Really sorry

@NastuzziSamy
Copy link
Author

@e-alfred I am confused, did you merged this PR ? ^^

@e-alfred
Copy link
Owner

e-alfred commented Jan 7, 2019

No, I didn't merge it, I just fixed some deprecated calls. At the moment there are UI issues with this PR on Nextcloud 14 and up which have to be fixed.

@e-alfred
Copy link
Owner

e-alfred commented Apr 7, 2019

@NastuzziSamy Any news on your rework? I still like the idea but it still needs some polish. One thing that would be great to have is a folder navigation option when clicking on the "+" button to make it easier for users to select and create folders where files should be uploaded.

@hezten
Copy link

hezten commented May 13, 2019

This is simply taking to long. Is there any way i can move the PR to a fork of the project ? I badly need this feature too :-)

@e-alfred
Copy link
Owner

@hezten If you want to finish this feature it would be awesome! To restart work on this PR you could just fork the flowupload repository of @NastuzziSamy from here:

https://github.com/NastuzziSamy/flowupload

Please make a new PR as soon as you finish your work so it can become part of the official release of Flowupload!

@Jon089
Copy link

Jon089 commented May 24, 2019

Has this become an official release by any chance?

@JonathanTreffler
Copy link
Collaborator

JonathanTreffler commented Nov 20, 2019

Because so many things changed in master i made another PR with the Changes from NastuzziSamy but in the latest flowupload version.

New PR: #73

@e-alfred
Copy link
Owner

e-alfred commented Nov 20, 2019

@JonathanTreffler Thanks for your help! Maybe we can close this PR if your new PR is good enough for merging?

@JonathanTreffler
Copy link
Collaborator

@TessyPowder Thanks for your help! Maybe we can close this PR if your new PR is good enough for merging?

Yes. That's probably a good idea

@NastuzziSamy
Copy link
Author

Hey guys, just saw what you did.

Thanks for taking your time finishing what I started, too busy this last years :/

Closing this :)

@NastuzziSamy
Copy link
Author

Actually, is this PR useless or I can rework on it ?

@NastuzziSamy NastuzziSamy reopened this Feb 10, 2020
@NastuzziSamy
Copy link
Author

NastuzziSamy commented Feb 10, 2020

Do not hesitate to personaly ping/email me if needed

@JonathanTreffler
Copy link
Collaborator

I am currently working on a implementation of this feature so this PR is probably not necessary anymore.

@NastuzziSamy
Copy link
Author

NastuzziSamy commented Feb 13, 2020

Can you then at least co-author me @JonathanTreffler in your commits ? I saw your PRS, where you are referencing me but not giving me credit 😊

@JonathanTreffler
Copy link
Collaborator

Can you then at least co-author me @TessyPowder in your commits ? I saw your PRS, where you are referencing me but not giving me credit 😊

Ok, how should i do that ?

@e-alfred
Copy link
Owner

PR #73 is fixing this feature finally, thanks for your help still!

@e-alfred e-alfred closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants