Skip to content

Commit

Permalink
Fixed Asqatasun#60 - Added the "required" attribute to the color fields
Browse files Browse the repository at this point in the history
  • Loading branch information
dzc34 committed Jun 8, 2017
1 parent c2feea7 commit edace49
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
15 changes: 9 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,27 @@

Contrast-Finder 0.4.8, 2017-0x-xx
Contrast-Finder 0.5.0, 2017-06-09
---------------------------------

Features:
none
- [#25 - Allowed RGB values in the form](https://github.com/Asqatasun/Contrast-Finder/issues/25)
- [#57 - Allowed color names (CSS3) in the form](https://github.com/Asqatasun/Contrast-Finder/issues/57)

Security:
none
- [#54 - Upgraded SpringFramework to v4.3.9](https://github.com/Asqatasun/Contrast-Finder/issues/54)

Bugs:
- [#53 - White space allowed around the color in the form](https://github.com/Asqatasun/Contrast-Finder/issues/53)
- [#53 - White spaces allowed around the color in the form](https://github.com/Asqatasun/Contrast-Finder/issues/53)
- [#55 - Added "back to the homepage" link](https://github.com/Asqatasun/Contrast-Finder/issues/55)
- [#58 - Associated the user tips with the color fields](https://github.com/Asqatasun/Contrast-Finder/issues/58)
- [#60 - Added the "required" attribute to the color fields](https://github.com/Asqatasun/Contrast-Finder/issues/60)

Configuration:
- [#52 - contrast-finder.conf: added option for debugging](https://github.com/Asqatasun/Contrast-Finder/issues/52)

Documentation:
none

Upgrade-o-meter:
just replace the .war file and restart Tomcat
Upgrade-o-meter: just replace the .war file and restart Tomcat


Contrast-Finder 0.4.7, 2017-06-01
Expand Down
4 changes: 2 additions & 2 deletions contrast-finder-webapp/src/main/webapp/WEB-INF/pages/form.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<div class="form-group ${foregroundOnError}">
<label for="foreground-input" class="col-lg-3 control-label"><fmt:message key="form.foregroundColor"/></label>
<div class="col-lg-4">
<form:input path="foreground"
<form:input path="foreground" required="required"
id="foreground-input" aria-describedby="help-block-foreground"
type="text" class="form-control"/>
<span id="help-block-foreground" class="help-block"><fmt:message key="form.help"/></span>
Expand Down Expand Up @@ -89,7 +89,7 @@
<div class="form-group ${backgroundOnError}">
<label for="background-input" class="col-lg-3 control-label"><fmt:message key="form.backgroundColor"/></label>
<div class="col-lg-4">
<form:input path="background"
<form:input path="background" required="required"
id="background-input" aria-describedby="help-block-background"
type="text" class="form-control"/>
<span id="help-block-background" class="help-block"><fmt:message key="form.help"/></span>
Expand Down

0 comments on commit edace49

Please sign in to comment.