-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Sftp
source and Prefect tasks
#1039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a look at them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the feedback still needs to be addressed, otherwise I think 90% is either done or requires an issue to be created & linked.
Tests are in progress. @trymzet please take a look at the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor things left. Also, pls make sure that CI passes before requesting PR, otherwise it's added work for me since I need to look at the same PR twice.
Co-authored-by: Michał Zawadzki <[email protected]>
Summary
SFTP connector migration from viadot 1 to viadot 2.
Importance
Required by the migration project.
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md