MFI Indicator #30
MFI Indicator #30
Conversation
|
|
||
|
|
||
| """ | ||
| MFI (Money Flow Index) gives almost the same results as tradingview.com |
There was a problem hiding this comment.
Documentation comments should follow the same convention as other functions (function signature in triple-backticks followed by indicator name/interpretation two lines below).
| """ | ||
| MFI (Money Flow Index) gives almost the same results as tradingview.com | ||
| """ | ||
| function MFI_logic(x::Array{T}; n::Int64=14, args...)::Array{T} where {T<:Real} |
There was a problem hiding this comment.
Function naming convention is all lowercase, e.g. mfi.
| end | ||
|
|
||
| ##### X::TS should contain traditional OHLC+Volume too | ||
| function MFI(X::TS, flds::Vector{Symbol}; args...) |
There was a problem hiding this comment.
Same comment about naming convention. The MFI method that takes a TS type as input should go in src/temporal.jl and should have the same function name as the base Array type method (mfi). Julia will automatically know which method to apply based on the input types :)
There was a problem hiding this comment.
@darthur11 Thanks for submitting this PR so quickly! Would love to get this indicator added. See comments in src/mom.jl. It would also be a good idea to add test cases to ensure the functions work as intended.
I'm not expert in Julia, it's my first attempt, so if you have any suggestions I'm glad to make edits. Also, I plan to implement OBV too.