refactor(hash): improve code readability, try to avoid multiple hash initialization and expose also shake256 in zencode hash statement #1003
+45
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matteo-cristino
commented
Jan 13, 2025
matteo-cristino
commented
- refactor(zenroom_hash): improve code readibility in hash initialization
- refactor(zenroom_hash): if present use already initialize hash everywhere
- refactor: more readable and easy to extend code for hashing statements
matteo-cristino
changed the title
…tements add also shake256 to list of usable hashes from zencode statement
matteo-cristino
force-pushed
the
refactor/hash
branch
from
ea20ca3 to
9c095fe
Compare
|
This was very needed! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.