Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: 👷 improve various aspect #53

Merged
merged 9 commits into from
Oct 6, 2023
Merged

ci: 👷 improve various aspect #53

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
398fac2
ci(release): 👷 perform release only on test success
matteo-cristino Oct 6, 2023
95be444
ci(release): 👷 gh release are not draft
matteo-cristino Oct 6, 2023
bcd66c2
ci(release): 👷 set npm package access to public
matteo-cristino Oct 6, 2023
5deb36e
ci: 👷 use npm instead of yarn
matteo-cristino Oct 6, 2023
ffbe8d0
ci(tests): 👷 use npm ci instead of npm install
matteo-cristino Oct 6, 2023
6e8e159
fix(bindings): 🐛 substitute yarn.lock with package-lock.json
matteo-cristino Oct 6, 2023
e209b75
ci(test): 👷 replace one more npm install with npm ci
matteo-cristino Oct 6, 2023
fec8079
fix(restroom): 🐛 substitute yarn.lock with package-lock.json
matteo-cristino Oct 6, 2023
f82be9c
ci(tests): 👷 drop node14 usage and add node latest version
matteo-cristino Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ jobs:
semantic-release:
name: 🤖 Semantic release
runs-on: ubuntu-latest
if: "!contains(github.event.pull_request.labels.*.name, 'skip-release')"
# if: ${{ github.ref_name == 'main' && github.event_name == 'push' }}
if: |
${{ github.event.workflow_run.conclusion == 'success' &&
!contains(github.event.pull_request.labels.*.name, 'skip-release') }}
outputs:
release: ${{ steps.tag_release.outputs.release }}
version: ${{ steps.tag_release.outputs.version }}
Expand Down Expand Up @@ -55,7 +56,6 @@ jobs:
- uses: softprops/action-gh-release@v1
with:
tag_name: ${{ needs.semantic-release.outputs.version }}
draft: true
prerelease: false
generate_release_notes: true

Expand All @@ -79,8 +79,8 @@ jobs:
- name: 📌 Set version
run: |
version=${{ needs.semantic-release.outputs.version }}
yarn version --new-version ${version:1} --no-git-tag-version
npm version --new-version ${version:1} --no-git-tag-version
- name: 📦 Publish
run: npm publish . --tag latest
run: npm publish . --tag latest --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
cp test/restroom/test_keyring.json secrets/blockchains_client.json
cd restroom
mv .env.example .env
yarn && yarn run init
npm install && npm run init
- name: 🛫 Start restroom
uses: dyne/restroom-github-action@v1
with:
Expand Down Expand Up @@ -101,9 +101,9 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: ⏬ Install dependencies
run: yarn
run: npm install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to run npm ci

- name: 🏗️ Build javascript bindings
run: yarn build
run: npm run build
- name: ⏫ Upload artifact
if: ${{ matrix.node-version == '16.x' }}
uses: actions/upload-artifact@v3
Expand All @@ -114,4 +114,4 @@ jobs:
./bindings/javascript/README.md
./bindings/javascript/dist/
- name: 🧪 Test bindings node-${{ matrix.node-version }}
run: yarn test
run: npm test