merged US 15364 & BUG 15267 & BUG 15251 into this #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederik5480
reviewed
Sep 8, 2023
src/OrderProvider.cs
Outdated
| @@ -155,15 +156,27 @@ public override Schema GetOriginalSourceSchema() | |||
| tablesToRemove.Add(table); | |||
| else if (table.Name == "EcomOrders") | |||
| { | |||
| table.AddColumn(new SqlColumn(("OrderCustomerAccessUserExternalId"), typeof(string), SqlDbType.NVarChar, table, -1, | |||
| false, false, true)); | |||
| table.AddColumn(new SqlColumn(SourceColumnNameForDestinationOrderCustomerAccessUserId, typeof(string), SqlDbType.NVarChar, table, -1, false, false, true)); | |||
There was a problem hiding this comment.
Is the use of SourceColumnNameForDestinationOrderCustomerAccessUserId really right where it's been used here?
I thought OrderCustomerAccessUserExternalId was made as the constant for "OrderCustomerAccessUserExternalId"
frederik5480
reviewed
Sep 8, 2023
src/OrderProvider.cs
Outdated
| @@ -501,7 +538,7 @@ private void ProcessRow(Mapping mapping, ColumnMappingCollection columnMappings, | |||
| if (mapping != null && mapping.DestinationTable != null && mapping.DestinationTable.Name == "EcomOrders" && !string.IsNullOrEmpty(SourceColumnNameForDestinationOrderCustomerAccessUserId)) | |||
| { | |||
| object accessUserId = DBNull.Value; | |||
| var OrderCustomerAccessUserExternalIdMapping = columnMappings.Find(cm => string.Compare(cm.DestinationColumn.Name, "OrderCustomerAccessUserExternalId", true) == 0); | |||
| var OrderCustomerAccessUserExternalIdMapping = columnMappings.Find(cm => string.Compare(cm.DestinationColumn.Name, SourceColumnNameForDestinationOrderCustomerAccessUserId, true) == 0); | |||
frederik5480
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#15373