Merge pull request #36 from dynamicweb/dbe/22212-DUKA-SQL-order-expor…

…t-Divide-by-zero-error DUKA SQL order export Divide by zero error
dynamicweb · Nov 26, 2024 · 00885ce · 00885ce
2 parents dc6e3ef + e358892
commit 00885ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Dynamicweb.DataIntegration.Providers.OrderProvider.csproj b/src/Dynamicweb.DataIntegration.Providers.OrderProvider.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
-		<Version>10.8.3</Version>
+		<Version>10.8.4</Version>
 		<AssemblyVersion>1.0.0.0</AssemblyVersion>
 		<Title>Order Provider</Title>
 		<Description>Order Provider</Description>

diff --git a/src/OrderSourceReader.cs b/src/OrderSourceReader.cs
@@ -86,7 +86,7 @@ protected override string GetColumns()
                     }
                     break;
                 case "EcomOrderLines":
-                    columns = columns + ", (-1 * OrderLineTotalDiscountWithVAT) / OrderLinePriceWithVat * 100 as [OrderLineCalculatedDiscountPercentage]";
+                    columns = columns + ", (-1 * OrderLineTotalDiscountWithVAT) / NULLIF(OrderLinePriceWithVat, 0) * 100 as [OrderLineCalculatedDiscountPercentage]";
                     break;
 
             }
-Original file line number
+Diff line change
@@ Expand Up / @@ -86,7 +86,7 @@ protected override string GetColumns() @@
                         }
                         break;
                     case "EcomOrderLines":
-                        columns = columns + ", (-1 * OrderLineTotalDiscountWithVAT) / OrderLinePriceWithVat * 100 as [OrderLineCalculatedDiscountPercentage]";
+                        columns = columns + ", (-1 * OrderLineTotalDiscountWithVAT) / NULLIF(OrderLinePriceWithVat, 0) * 100 as [OrderLineCalculatedDiscountPercentage]";
                         break;
                 }
@@ Expand Down @@