Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change project target frameworks #225

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Conversation

metoule
Copy link
Contributor

@metoule metoule commented Jan 31, 2022

Fix #224

@metoule metoule requested a review from davideicardi as a code owner January 31, 2022 21:15
Copy link
Member

@davideicardi davideicardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davideicardi
Copy link
Member

@metoule Do you think we should really consider this as a breaking change? We will "break" only user on .NET 4.5. Ok technically speaking is a breaking change, but maybe we can just put a "BREAKING CHANGE" note in the release note.

@metoule
Copy link
Contributor Author

metoule commented Feb 9, 2022

Now that I think about it, Nuget should handle this for us: it will stop suggesting updates to users on .NET4.5, but they can still use the 2.10.0 version.
I agree with your suggestion to put a note in the release notes :)

@metoule metoule merged commit 5b185e9 into dynamicexpresso:master Feb 9, 2022
@metoule metoule deleted the fix_224 branch February 9, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET Framework 4.5.2 end of support is April 26, 2022
2 participants