-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bitwise operations support #208
Conversation
Added support of the shift operators (>> and <<). Fix dynamicexpresso#206
Note that I didn't add new tokens for the shift operators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good! Just a small comment.
Could you please add directives to unit tests for language versions that do not support it yet? |
Which language versions don't support it? The tests ran successfully for .NET Framework 4.5 and 4.6.1 and .NET Core 3.1 and 5.0. |
That's really strange - which version of Visual Studio are you using? It should work out of the box from VS2019 onwards. You can replace replace that variable declaration with any integer, for example For the other tests, var a = 0b_1111_1000;
var b = 0b_0001_1100; can be replaced with var a = 248;
var b = 28; Be careful for test |
Or you can install VS community edition :) |
Add support of the unary bitwise complement operator (~)
Add support of the shift operators (>> and <<)
Fix #206