Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken localization #328

Closed
cpiber opened this issue Nov 13, 2024 · 3 comments · Fixed by #329
Closed

Broken localization #328

cpiber opened this issue Nov 13, 2024 · 3 comments · Fixed by #329

Comments

@cpiber
Copy link
Contributor

cpiber commented Nov 13, 2024

#318 broke localization

Some strings are still localized (e.g. ErrorMessages.Format is still used), but many actually useful messages are hardcoded again, like "Unknown identifier"

: base(string.Format("Unknown identifier '{0}'", identifier), position)

@davideicardi
Copy link
Member

Thank you for the issue. You are right. We will try to resolve this issue in the future. As usual, any help is appreciated ;-) .

cpiber added a commit to cpiber/DynamicExpresso that referenced this issue Nov 15, 2024
@metoule
Copy link
Contributor

metoule commented Nov 16, 2024

Ooops sorry about that, I'll work on it 🙈

@cpiber
Copy link
Contributor Author

cpiber commented Nov 16, 2024

@metoule My PR that fixes it is already merged, I forgot to close this

@cpiber cpiber closed this as completed Nov 16, 2024
@metoule metoule linked a pull request Nov 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants