Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Github Workflow #231

Merged
merged 14 commits into from
Sep 16, 2022
Merged

CI Github Workflow #231

merged 14 commits into from
Sep 16, 2022

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Aug 27, 2022

No description provided.

@jsirish
Copy link
Member Author

jsirish commented Aug 28, 2022

@muskie9 any idea what's going on with the tests? Works on local running PHP8, SS 4.11 and PHPUNIT 9

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 61.89% // Head: 45.90% // Decreases project coverage by -15.99% ⚠️

Coverage data is based on head (7020a40) compared to base (81b291d).
Patch coverage: 12.71% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #231       +/-   ##
=============================================
- Coverage     61.89%   45.90%   -16.00%     
- Complexity      105      162       +57     
=============================================
  Files             7       13        +6     
  Lines           370      488      +118     
=============================================
- Hits            229      224        -5     
- Misses          141      264      +123     
Flag Coverage Δ
php ?
unittests 45.90% <12.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Model/Location.php 74.00% <ø> (ø)
src/Page/LocationPage.php 0.00% <0.00%> (ø)
src/Tasks/EmailAddressTask.php 0.00% <0.00%> (ø)
src/Tasks/LocationCategoriesTask.php 0.00% <ø> (ø)
src/Tasks/LocationPublishTask.php 0.00% <ø> (ø)
src/Tasks/LocationToPageTask.php 0.00% <0.00%> (ø)
src/admin/LocationAdmin.php 0.00% <0.00%> (ø)
src/admin/LocationsAdmin.php 0.00% <0.00%> (ø)
src/bulkloader/LocationCsvBulkLoader.php 0.00% <ø> (ø)
src/form/LocatorForm.php 97.67% <ø> (+16.27%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@muskie9
Copy link
Member

muskie9 commented Aug 30, 2022

@jsirish I was able to track it down. It was aspects of the composer file that snuck in with the work that converted locations to pages: 14ead80

"phploc/phploc": "^4.0",
"pdepend/pdepend": "^2.5",
"theseer/phpdox": "^0.11.0"
"silverstripe/recipe-testing": "^2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, assuming up the chain this is required (and/or we're not requiring behat testing) this can be removed.

@muskie9-opensource muskie9-opensource merged commit 04e369f into master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants