REFACTOR LocationPage modeling #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the overall model pattern to be Page based.
jsirish
reviewed
Mar 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=============================================
- Coverage 61.89% 45.89% -16.00%
- Complexity 105 161 +56
=============================================
Files 7 12 +5
Lines 370 512 +142
=============================================
+ Hits 229 235 +6
- Misses 141 277 +136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
since this will be used in a new major release, are there any objections to implementing #187 |
|
@mak001 good idea, let's make sure we get that tackled before releasing the new major. |
LocationPage * ShowInMenus default false * Moved contact info to CMS tab * getWebsiteURL() - add check for http/s
mak001
pushed a commit
that referenced
this pull request
Jul 28, 2022
Update the overall model pattern to be Page based.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the overall model pattern to be Page based.