Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed how the map script was generated #222

Merged
merged 2 commits into from
Feb 19, 2020

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Feb 5, 2020

  • allows extension points for modifying settings easily

  - allows extension points for modifying settings easily
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #222 into master will increase coverage by 1.36%.
The diff coverage is 8.1%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #222      +/-   ##
============================================
+ Coverage     60.52%   61.89%   +1.36%     
  Complexity      105      105              
============================================
  Files             7        7              
  Lines           380      370      -10     
============================================
- Hits            230      229       -1     
+ Misses          150      141       -9
Flag Coverage Δ Complexity Δ
#php 61.89% <8.1%> (+1.36%) 105 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/pages/LocatorController.php 56.09% <8.1%> (+3.46%) 35 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d6d1a8...9e3cf3d. Read the comment docs.

@mak001 mak001 requested review from jsirish and muskie9 February 6, 2020 16:34
Copy link
Member

@jsirish jsirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to follow without pulling it down but looks pretty good to me.

We may want to incorporate this PR, since you're hitting some of the same logic #220

@mak001
Copy link
Contributor Author

mak001 commented Feb 17, 2020

After reviewing the changes in #220 they could be merged separately without any negative effects

  - not great, but its something
@mak001 mak001 changed the base branch from 3.1 to master February 17, 2020 19:46
@mak001 mak001 changed the base branch from master to 3.1 February 19, 2020 15:55
@mak001 mak001 merged commit 13d2d90 into dynamic:3.1 Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants