Front end uses react and redux #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=============================================
+ Coverage 53.3% 83.26% +29.95%
+ Complexity 73 54 -19
=============================================
Files 7 26 +19
Lines 257 502 +245
Branches 0 59 +59
=============================================
+ Hits 137 418 +281
+ Misses 120 84 -36
Continue to review full report at Codecov.
|
- just outputs two components with text
- now need to get the backend to spit out the locations
Linted JS - Formatting and renaming - added .eslintrc - updated .editorconfig to reflect .eslintrc
Started to implement radius search
Added some documentation Updated eslint to ignore long comments (mainly for docs)
- no proccessing yet Moved some search stuff around Added more docs
- fails to update?
- relies on 3rd party react package to render map and markers Started to trim down controller - all of what is gone was uneeded
- added style rule to override stupid margin on ul
- for info window - Added new action types
- imports are now on a relative path from client/src folder now 'focuses' on related location in list when clicking a marker
- not fully hooked up with react
- don't know how to allow distance to be used in graphql (kept getting 'not a field' errors)
- Uses a 'new' controller so it can have its own queries
- Allows users without cms access to use the endpoint
- Part of why a new controller, so everything on the main controller was not exposed
- only outputs json of what is to be rendered
- allows setting default map settings
Created a reducer to make a section in the store to store the settings
- not hardcoded into javascript
- duplicate values otherwise
mak001
force-pushed
the
react-no-graphql
branch
2 times, most recently
from
64a4898 to
0478ae1
Compare
- Removes xdebug config - split php test coverage into two lines (coverage still needs to succed to download the scrutinizer stuff) - scrutinizer no longer relies on codecov submission to submit
mak001
force-pushed
the
react-no-graphql
branch
from
0478ae1 to
4782f65
Compare
- should fix some speed issues with setting up js tests
- css now compiles to /css instead of /client/dist/css Css is now loaded via themedCSS in the template Javascript requirements now load in using the module name, not the path Updated gitattributes
mak001
force-pushed
the
react-no-graphql
branch
from
ec3ffd8 to
bc58162
Compare
test file structure now replicates src
- now uses same basic method as Requirements class loads javascript/css
Fixed js error when there are no categories
- faster future builds
mak001
force-pushed
the
react-no-graphql
branch
from
ad26c47 to
c0f9356
Compare
- Open source doesn't need this Made javascript coverage use bash instead of npm module
- recent pr to make module a vedor module seems to have messed something up
mak001
force-pushed
the
react-no-graphql
branch
from
fa7bca5 to
0f6b1a1
Compare
- now uses pgsql and sqlite versions some silverstripe modules are using locations json is now valid if there is no distance provided
cleaned up imports for category tests
fixed getEditForm properly remove delete action
|
Closing to opt for optional front end module(s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of locations sometimes acts funky when scrolling to a location in a long list. May want to paginate the resulting list on client side.
ping #34
ping #115
ping #116
ping #117
ping #118