Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Names #170

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Table Names #170

merged 1 commit into from
Jul 7, 2017

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jul 7, 2017

misc cleanup

  • require GridFieldExtensions
  • Locator - remove $this->extend('updateCMSFields', $fields);
  • LocatorForm - bugfix - hide Categories dropdown if no categories in system

misc cleanup

* require GridFieldExtensions
* Locator - remove `$this->extend('updateCMSFields', $fields);`
* LocatorForm - bugfix - hide Categories dropdown if no categories in system
@codecov
Copy link

codecov bot commented Jul 7, 2017

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   52.69%   52.69%           
=======================================
  Files           9        9           
  Lines         315      315           
=======================================
  Hits          166      166           
  Misses        149      149
Impacted Files Coverage Δ
src/objects/LocationCategory.php 100% <ø> (ø) ⬆️
src/pages/LocatorController.php 19.64% <ø> (ø) ⬆️
src/objects/Location.php 100% <ø> (ø) ⬆️
src/form/LocatorForm.php 77.14% <0%> (-4.68%) ⬇️
src/pages/Locator.php 90.9% <100%> (+5.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd845a2...faaf377. Read the comment docs.

@jsirish jsirish requested a review from muskie9 July 7, 2017 20:17
@jsirish jsirish merged commit c89ab0c into dynamic:master Jul 7, 2017
@jsirish jsirish deleted the feature/tableNames branch July 7, 2017 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants