Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated docs #165

Merged
merged 4 commits into from
Jul 25, 2017
Merged

updated docs #165

merged 4 commits into from
Jul 25, 2017

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Jun 19, 2017

Now includes an example of requiring a different script.

@mak001
updated docs
93e3167 
  - includes example of requiring a different script.
@mak001 mak001 requested review from muskie9 and jsirish June 19, 2017 18:30
@codecov
Copy link

codecov bot commented Jun 19, 2017 •
edited
Loading

Codecov Report

Merging #165 into 2.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.0     #165   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files           5        5           
  Lines         311      311           
=======================================
  Hits          182      182           
  Misses        129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0b5771...86614e2. Read the comment docs.

jsirish
jsirish reviewed Jun 20, 2017
View reviewed changes
Copy link
Member

@jsirish jsirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks pretty good!

I might flush it out a bit more - show the class CustomLocator extends Locator declaration at the top of the php example so it's more clear that we're extending the base class.

muskie9
muskie9 requested changes Jul 25, 2017
View reviewed changes
Copy link
Member

@muskie9 muskie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in pretty good shape. Saw the one thing with the class declaration in the example, otherwise it seems pretty well put together.

docs/en/code/index.md Outdated
This example shows how to reference custom templates and a custom data location. It is recommended to copy the custom script from the [Locator Controller](../../../code/pages/Locator.php#L273-L298) and modify it.

```php
class Locator_ControllerExtension extends DataExtension
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is applied to the Locator_Controller it should extend Extension rather than DataExtension.

@mak001 mak001 merged commit 8c1bc89 into dynamic:2.0 Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsirish jsirish jsirish left review comments

@muskie9 muskie9 muskie9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mak001 @muskie9 @jsirish