Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a unique ID to custom script #164

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Added a unique ID to custom script #164

merged 1 commit into from
Jun 13, 2017

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Jun 13, 2017

 - allows for more customization
Updated gitignore
Copy link
Member

@muskie9 muskie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do you have any documentation/examples for developers we could include in the readme for instances they may leverage this. Could do a separate PR for that if there is anything.

@codecov
Copy link

codecov bot commented Jun 13, 2017

Codecov Report

Merging #164 into 2.0 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.0     #164   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files           5        5           
  Lines         311      311           
=======================================
  Hits          182      182           
  Misses        129      129
Impacted Files Coverage Δ
code/pages/Locator.php 36.52% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecedba4...4cc676f. Read the comment docs.

@muskie9 muskie9 merged commit 8cd9f35 into dynamic:2.0 Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants