Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SilverStripe alpha7 updates #160

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented May 16, 2017

use dynamic/silverstripe-geocoder for geocoding

@codecov
Copy link

codecov bot commented May 16, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b300f9d). Click here to learn what that means.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #160   +/-   ##
=========================================
  Coverage          ?   52.38%           
=========================================
  Files             ?        9           
  Lines             ?      315           
  Branches          ?        0           
=========================================
  Hits              ?      165           
  Misses            ?      150           
  Partials          ?        0
Impacted Files Coverage Δ
src/admin/LocationAdmin.php 0% <ø> (ø)
src/bulkloader/LocationCsvBulkLoader.php 0% <ø> (ø)
src/objects/LocationCategory.php 100% <100%> (ø)
src/form/LocatorForm.php 81.81% <100%> (ø)
src/pages/LocatorController.php 19.64% <17.64%> (ø)
src/extensions/DistanceDataExtension.php 46.15% <20%> (ø)
src/extensions/AddressDataExtension.php 51.16% <51.16%> (ø)
src/pages/Locator.php 85.71% <85.71%> (ø)
src/objects/Location.php 97.29% <94.73%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b300f9d...322c08c. Read the comment docs.

@jsirish jsirish force-pushed the refactor/ssA7 branch 2 times, most recently from 5ce3ff8 to 5aad947 Compare May 16, 2017 21:02
use dynamic/silverstripe-geocoder for geocoding
@muskie9 muskie9 self-requested a review June 8, 2017 15:12
Copy link
Member

@muskie9 muskie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checks out in my local testing 👍

I'm going to add a ticket to pull in the new community Country dropdown field

@muskie9 muskie9 merged commit dd845a2 into dynamic:master Jun 8, 2017
@mak001 mak001 mentioned this pull request Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants