Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Locator - remove autoGeocode references #156

Merged
merged 1 commit into from
Apr 18, 2017
Merged

BUGFIX: Locator - remove autoGeocode references #156

merged 1 commit into from
Apr 18, 2017

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Apr 17, 2017

closes #155

@jsirish jsirish requested a review from muskie9 April 17, 2017 17:09
@codecov
Copy link

codecov bot commented Apr 17, 2017 •
edited
Loading

Codecov Report

Merging #156 into 2.0 will increase coverage by 2.27%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.0     #156      +/-   ##
==========================================
+ Coverage   56.25%   58.52%   +2.27%     
==========================================
  Files           5        5              
  Lines         320      311       -9     
==========================================
+ Hits          180      182       +2     
+ Misses        140      129      -11
Impacted Files Coverage Δ
code/pages/Locator.php 36.52% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7a947...41b6083. Read the comment docs.

muskie9
muskie9 approved these changes Apr 18, 2017
View reviewed changes
Copy link
Member

@muskie9 muskie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jsirish jsirish force-pushed the bugfix/autoGeocodeSafari branch from 428c974 to 41b6083 Compare April 18, 2017 18:41
@jsirish jsirish merged commit ecedba4 into dynamic:2.0 Apr 18, 2017
@jsirish jsirish deleted the bugfix/autoGeocodeSafari branch April 18, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muskie9 muskie9 muskie9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirish @muskie9