Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update store locator JS #142

Merged
merged 1 commit into from
Feb 12, 2017
Merged

Update store locator JS #142

merged 1 commit into from
Feb 12, 2017

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Feb 11, 2017

closes #129
closes #120

@codecov
Copy link

codecov bot commented Feb 11, 2017

Codecov Report

Merging #142 into 2.0 will decrease coverage by -2.64%.

@@            Coverage Diff             @@
##              2.0     #142      +/-   ##
==========================================
- Coverage   69.42%   66.78%   -2.64%     
==========================================
  Files           5        5              
  Lines         278      280       +2     
==========================================
- Hits          193      187       -6     
- Misses         85       93       +8
Impacted Files Coverage Δ
code/pages/Locator.php 53.33% <18.75%> (-4.78%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7142d76...fbb456d. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 11, 2017

Codecov Report

Merging #142 into 2.0 will decrease coverage by -13.62%.
The diff coverage is 12.5%.

@@             Coverage Diff             @@
##              2.0     #142       +/-   ##
===========================================
- Coverage   69.42%   55.81%   -13.62%     
===========================================
  Files           5        5               
  Lines         278      301       +23     
===========================================
- Hits          193      168       -25     
- Misses         85      133       +48
Impacted Files Coverage Δ
code/pages/Locator.php 35.67% <12.5%> (-22.44%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7142d76...5cf2396. Read the comment docs.

@jsirish jsirish requested a review from muskie9 February 11, 2017 06:47
@jsirish jsirish force-pushed the refactor/locatorJS branch 4 times, most recently from 253157c to 8ad3266 Compare February 11, 2017 20:36
@jsirish
Copy link
Member Author

jsirish commented Feb 11, 2017

I've been bouncing back and forth between a fresh install, and Perlick. Works well in both instances.

Perlick required minimal work in config to integrate

@jsirish jsirish force-pushed the refactor/locatorJS branch 5 times, most recently from 3cc228b to a56a236 Compare February 12, 2017 02:13
@jsirish jsirish merged commit ba0a07f into dynamic:2.0 Feb 12, 2017
@jsirish jsirish deleted the refactor/locatorJS branch February 12, 2017 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant