Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location - versioning #141

Merged
merged 4 commits into from
Feb 22, 2017
Merged

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Feb 10, 2017

closes #140

@jsirish jsirish requested a review from muskie9 February 10, 2017 22:31
@jsirish jsirish force-pushed the feature/locationVersioning branch 3 times, most recently from 8a17a0d to 5bedaba Compare February 10, 2017 22:40
@jsirish jsirish force-pushed the feature/locationVersioning branch from 5bedaba to a244592 Compare February 10, 2017 22:43
@codecov
Copy link

codecov bot commented Feb 10, 2017

Codecov Report

Merging #141 into 2.0 will decrease coverage by -0.63%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              2.0     #141      +/-   ##
==========================================
- Coverage   55.81%   55.18%   -0.63%     
==========================================
  Files           5        5              
  Lines         301      299       -2     
==========================================
- Hits          168      165       -3     
- Misses        133      134       +1
Impacted Files Coverage Δ
code/pages/Locator.php 34.7% <ø> (-0.97%)
code/objects/Location.php 89.23% <100%> (-0.17%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74ca62...def6fdf. Read the comment docs.

Copy link
Member

@muskie9 muskie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, will merge once tests are green 👍

@muskie9 muskie9 merged commit e93c292 into dynamic:2.0 Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants