Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Geocoding #135

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Google Geocoding #135

wants to merge 4 commits into from

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Dec 16, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 16, 2016

Current coverage is 11.67% (diff: 32.18%)

Merging #135 into master will decrease coverage by 45.75%

@@             master       #135   diff @@
==========================================
  Files             4          3     -1   
  Lines           249        257     +8   
  Methods          24         28     +4   
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            143         30   -113   
- Misses          106        227   +121   
  Partials          0          0          

Powered by Codecov. Last update 486554f...574a2c7

@jsirish
Copy link
Member Author

jsirish commented Dec 16, 2016

i'll clean up some tests before we merge this.

@muskie9 we've lost the distance calculation stuff in SS4. It seems the augmentSQL isn't catching on Locator_Controller::setLocations(). Default coords are working in init() however

@jsirish jsirish force-pushed the feature/geocoding branch 3 times, most recently from e0ed01f to 754afcc Compare December 17, 2016 03:21
@muskie9
Copy link
Member

muskie9 commented Dec 17, 2016

I'm looking into the augmentSQL() update in 4. If that's the only thing that holds this PR up we can merge and I'll open a new PR if I find something.

require dynamic/silverstripe-geocoder
@jsirish jsirish force-pushed the feature/geocoding branch 2 times, most recently from 762af40 to 574a2c7 Compare December 17, 2016 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants