-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Locations Indication in template #7
Comments
Would this be fixed by adding default records similar to the Blog module on dev/build? |
That’s one way to do it, would work well for initial install of module. However, I was thinking of a scenario where locations are more fluid - maybe one day, there’s a couple mapped locations, but the next there are none. Would be a simple message like “No locations have been posted, please check back soon”, and would skip all of the JS script execution. On May 5, 2014, at 11:11 PM, muskie9 [email protected] wrote:
|
So something like this (only requiring js if there are locations from the getter method) :
|
Yeah exactly. But we may need to disable the JS init call in the controller as well so we don't get a bunch of JS errors without the required Divs. |
Update Locator to handle null locations fixes #7
Add some language to the default template indicating when there are no locations created or meeting the criteria to show on map. Currently seems to be confusing to people installing the module for the first time.
The text was updated successfully, but these errors were encountered: