Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT locator v4 support #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

muskie9
Copy link
Member

@muskie9 muskie9 commented Mar 19, 2020

No description provided.

@muskie9 muskie9 requested a review from mak001 March 19, 2020 23:38
@codeclimate
Copy link

codeclimate bot commented Mar 19, 2020

Code Climate has analyzed commit 35349aa and detected 0 issues on this pull request.

View more on Code Climate.

@muskie9 muskie9 force-pushed the pull/locator4Support branch from 2ebea52 to 1375c32 Compare March 19, 2020 23:39
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage     61.15%   61.15%           
  Complexity       47       47           
=========================================
  Files            34       34           
  Lines           713      713           
  Branches        122      122           
=========================================
  Hits            436      436           
  Misses          273      273           
  Partials          4        4
Flag Coverage Δ Complexity Δ
#js 61.36% <ø> (ø) 0 <ø> (ø) ⬇️
#php 60.46% <ø> (ø) 47 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a892e1c...35349aa. Read the comment docs.

@mak001
Copy link
Contributor

mak001 commented Mar 20, 2020

After looking at why the travis build fails, we may actually need the package-lock.json file or to change the travis.yml file to use npm install instead of npm ci

re-adds package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants