Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to use custom map styles #19

Merged
merged 4 commits into from
Jun 1, 2018
Merged

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Apr 16, 2018

Added custom marker icon support

Relies on dynamic/silverstripe-geocoder#24 and dynamic/silverstripe-locator#185

@codecov
Copy link

codecov bot commented Apr 16, 2018

Codecov Report

Merging #19 into master will decrease coverage by 0.38%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
- Coverage     94.87%   94.49%   -0.39%     
  Complexity       11       11              
============================================
  Files            26       26              
  Lines           449      472      +23     
  Branches         78       85       +7     
============================================
+ Hits            426      446      +20     
- Misses           23       26       +3
Flag Coverage Δ Complexity Δ
#js 93.76% <91.17%> (-0.36%) 0 <0> (ø)
#php 100% <100%> (ø) 11 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
client/src/js/actions/ActionTypes.js 100% <100%> (ø) 0 <0> (ø) ⬇️
client/src/js/components/Locator.jsx 100% <100%> (ø) 0 <0> (ø) ⬇️
client/src/js/actions/settingsActions.js 100% <100%> (ø) 0 <0> (ø) ⬇️
src/Extensions/LocatorControllerExtension.php 100% <100%> (ø) 10 <0> (ø) ⬇️
client/src/js/reducers/settingsReducer.js 100% <100%> (ø) 0 <0> (ø) ⬇️
client/src/js/components/map/Map.jsx 89.47% <60%> (-10.53%) 0 <0> (ø)
client/src/js/components/map/MapContainer.jsx 91.66% <66.66%> (-2.62%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028e0fc...a9cdc35. Read the comment docs.

@mak001 mak001 merged commit 72f6e4d into dynamic:master Jun 1, 2018
@mak001 mak001 deleted the map-styles branch June 1, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant