Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added froopyland as an option to the network list #423

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

omritoptix
Copy link
Collaborator

@omritoptix omritoptix commented Aug 21, 2023

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix requested a review from a team as a code owner August 21, 2023 16:57
@omritoptix omritoptix linked an issue Aug 21, 2023 that may be closed by this pull request
@omritoptix
Copy link
Collaborator Author

@ItayLevyOfficial Currently the tests fails as the unit-test relays on the default hub endpoint (in this case froopyland) to be up and running (froopyland is still not up and running hence it fails) .

We should change the test to either run a dummy hub or mock the hub response as it's prone to failures as unit test shouldn't rely on external sources .

Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omritoptix omritoptix merged commit 37a1aae into main Aug 22, 2023
@omritoptix omritoptix deleted the omritoptix/422-froopyland-network branch August 22, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add froopyland to the list of available networks
2 participants