Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a no-output flag to roller init and register #406

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Aug 17, 2023

Needed to make the roller work in non-interactive terminals, such as in a GitHub CD flow

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Aug 17, 2023 that may be closed by this pull request
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review August 17, 2023 08:17
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner August 17, 2023 08:17
Copy link
Collaborator

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead of adding if before each command for checking for no-output flag it's better to have all the output being sent to one function, and based on the caller you handle the relevant output.
by that you can simply check once (only in this function) if the no-output flag is set.
Otherwise it seems very fragile an error-prone IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow init and register to run with the --no-output flag
2 participants