Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Change relayer to use a single logger instance #403

Merged
merged 2 commits into from
Aug 17, 2023
Merged

chore: Change relayer to use a single logger instance #403

merged 2 commits into from
Aug 17, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Aug 16, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Aug 16, 2023 that may be closed by this pull request
roller relayer start should not create a logger instance on every command execution #402
Closed
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review August 16, 2023 15:00
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner August 16, 2023 15:00
@ItayLevyOfficial ItayLevyOfficial marked this pull request as draft August 16, 2023 15:01
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review August 16, 2023 15:02
omritoptix
omritoptix approved these changes Aug 16, 2023
View reviewed changes
cmd/utils/log.go
@@ -23,6 +23,13 @@ func WithLogging(logFile string) CommandOption {
}
}

func WithLoggerLogging(logger *log.Logger) CommandOption {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the name it's hard to understand what this function does.

@ItayLevyOfficial ItayLevyOfficial merged commit f13c0c1 into main Aug 17, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/402-single-relayer-logger branch August 17, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roller relayer start should not create a logger instance on every command execution
2 participants
@ItayLevyOfficial @omritoptix