Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add local hub initialization logic to roller config init #381

Merged
merged 22 commits into from
Aug 15, 2023
Merged

feat: Add local hub initialization logic to roller config init #381

merged 22 commits into from
Aug 15, 2023

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Aug 14, 2023 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial changed the base branch from main to itaylevyofficial/366-configurable-lc-port August 14, 2023 09:17
@ItayLevyOfficial ItayLevyOfficial linked an issue Aug 14, 2023 that may be closed by this pull request
roller config init should init hub configuration same as the setup_local script #370
Closed
Base automatically changed from itaylevyofficial/366-configurable-lc-port to main August 14, 2023 14:55
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review August 14, 2023 15:11
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner August 14, 2023 15:11
mtsitrin
mtsitrin reviewed Aug 14, 2023
View reviewed changes
cmd/config/init/local_hub.go Outdated Show resolved Hide resolved
cmd/config/init/local_hub.go Outdated Show resolved Hide resolved
cmd/config/init/local_hub.go Outdated Show resolved Hide resolved
cmd/config/init/unique_rollapp_id.go Outdated Show resolved Hide resolved
cmd/config/init/local_hub.go Outdated Show resolved Hide resolved
cmd/config/init/local_hub.go Outdated Show resolved Hide resolved
mtsitrin
mtsitrin reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@mtsitrin mtsitrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls change the listening addr to 127.0.0.1
and remove the cors

no need for this, we not gonna expose this machine

@ItayLevyOfficial ItayLevyOfficial merged commit 9f896f7 into main Aug 15, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/370-init-local-hub branch August 15, 2023 12:00
This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roller config init should init hub configuration same as the setup_local script
2 participants
@ItayLevyOfficial @mtsitrin