chore: Remove hard-coded log level from roller sequencer start command #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
reviewed
Aug 7, 2023
| @@ -71,8 +71,6 @@ func GetStartRollappCmd(rollappConfig config.RollappConfig) *exec.Cmd { | |||
| "start", | |||
| "--home", rollappConfigDir, | |||
| "--log-file", filepath.Join(rollappConfigDir, "rollapp.log"), | |||
| "--log_level", "debug", | |||
| "--max-log-size", "2000", | |||
There was a problem hiding this comment.
why u removed the max log size? to be default?
mtsitrin
approved these changes
Aug 7, 2023
ItayLevyOfficial
deleted the
itaylevyofficial/201-configurable-log-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to update the migration code, as SetTMConfig is already being invoked in the v_0_1_6 migrator
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: