Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove log file parameter from roller services load command #327

Merged

Conversation

ItayLevyOfficial
Copy link
Contributor

@ItayLevyOfficial ItayLevyOfficial commented Jul 30, 2023

This PR removes the log file parameter from the roller services load command as it was causing conflicts with the internal service writing all logs to the same file, thereby breaking the application and being redundant

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@ItayLevyOfficial ItayLevyOfficial linked an issue Jul 30, 2023 that may be closed by this pull request
@ItayLevyOfficial ItayLevyOfficial marked this pull request as ready for review July 30, 2023 10:46
@ItayLevyOfficial ItayLevyOfficial requested a review from a team as a code owner July 30, 2023 10:46
@ItayLevyOfficial ItayLevyOfficial merged commit b901fd3 into main Jul 30, 2023
@ItayLevyOfficial ItayLevyOfficial deleted the itaylevyofficial/325-remove-services-log-file branch July 30, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relayer service shoudln't overide the stdout
2 participants