Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

126 add optional override flag when establishing ibc connection #312

Merged
merged 11 commits into from
Jul 30, 2023
Merged

126 add optional override flag when establishing ibc connection #312

merged 11 commits into from
Jul 30, 2023

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin linked an issue Jul 27, 2023 that may be closed by this pull request
add optional override flag when establishing IBC connection #126
Closed
@mtsitrin mtsitrin marked this pull request as ready for review July 27, 2023 18:29
@mtsitrin mtsitrin requested a review from a team as a code owner July 27, 2023 18:29
ItayLevyOfficial
ItayLevyOfficial approved these changes Jul 30, 2023
View reviewed changes
relayer/create_ibc_channel.go
@@ -39,13 +38,13 @@ func (r *Relayer) CreateIBCChannel(logFileOption utils.CommandOption) (Connectio
return ConnectionChannels{}, err
}

createConnectionCmd := r.getCreateConnectionCmd()
createConnectionCmd := r.getCreateConnectionCmd(override)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why pass the override flag? you are already checking on it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's additional flag on the actual rly command

@mtsitrin mtsitrin merged commit 8ddd173 into main Jul 30, 2023
@mtsitrin mtsitrin deleted the 126-add-optional-override-flag-when-establishing-ibc-connection branch July 30, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItayLevyOfficial ItayLevyOfficial ItayLevyOfficial approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add optional override flag when establishing IBC connection
2 participants
@mtsitrin @ItayLevyOfficial