Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bank denom metadata to rollapp genesis #292

Merged

Conversation

VictorTrustyDev
Copy link
Contributor

@VictorTrustyDev VictorTrustyDev commented Jul 18, 2023

PR Standards

Opening a pull request should be able to meet the following requirements

Closes: #293 & #168

Note: I'm just implement this without writing test cases. If needed, please feel free to implement it by yourself with additional code and close this PR.

Result:

rollapp_evm --home ~/.roller/rollapp start 2>&1 > /dev/null &
rollapp_evm --home ~/.roller/rollapp q bank denom_metadata
metadatas:
- base: uRAX
  denom_units:
  - aliases: []
    denom: uRAX
    exponent: 0
  - aliases: []
    denom: RAX
    exponent: 18
  description: Denom metadata for RAX (uRAX)
  display: RAX
  name: Rax
  symbol: RAX
  uri: ""
  uri_hash: ""
pagination:
  next_key: null
  total: "1"

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@VictorTrustyDev VictorTrustyDev marked this pull request as ready for review July 18, 2023 16:54
@VictorTrustyDev VictorTrustyDev requested a review from a team as a code owner July 18, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: Missing denom metadata in RollApp genesis file
2 participants