Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: denom accepts 3-6 letters #200

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/config/init/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ A valid RollApp ID should follow the format 'name_uniqueID-revision', where
- 'uniqueID' is a number up to the length of 5 digits representing the unique ID EIP155 rollapp ID
- 'revision' is a number up to the length of 5 digits representing the revision number for this rollapp

A valid denom should consist of exactly 3 English alphabet letters, for example 'btc', 'eth'`
A valid denom should consist of 3-6 English alphabet letters, for example, 'btc', 'eth', 'pepe', etc.`
}

func runInit(cmd *cobra.Command, args []string) error {
Expand Down
5 changes: 3 additions & 2 deletions cmd/consts/consts.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ var KeysIds = struct {
HubSequencer: "hub_sequencer",
RollappSequencer: "rollapp_sequencer",
RollappRelayer: "relayer-rollapp-key",
DALightNode: "da-key",
HubRelayer: "relayer-hub-key",
//TODO(#76): da key name should be more generic
DALightNode: "my_celes_key",
HubRelayer: "relayer-hub-key",
}

var AddressPrefixes = struct {
Expand Down
1 change: 0 additions & 1 deletion cmd/register/register.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
"github.com/dymensionxyz/roller/cmd/consts"

initconfig "github.com/dymensionxyz/roller/cmd/config/init"
"github.com/dymensionxyz/roller/cmd/consts"
"github.com/dymensionxyz/roller/cmd/utils"
"github.com/dymensionxyz/roller/config"
"github.com/spf13/cobra"
Expand Down
2 changes: 1 addition & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func IsValidDenom(s string) error {
}

func IsValidTokenSymbol(s string) bool {
if len(s) != 3 {
if len(s) < 3 || len(s) > 6 {
return false
}
for _, r := range s {
Expand Down