feat: sequencer registration (#821)

.github/workflows/e2e.yml

@@ -3,7 +3,7 @@ on:
   workflow_dispatch:
 jobs:
   end_to_end_test:
-    runs-on: ["arm-linux"]
+    runs-on: ["self-hosted"]
     env:
       GOPRIVATE: "github.com/dymensionxyz/*"
       GH_ACCESS_TOKEN: "${{ secrets.GH_ACCESS_TOKEN }}"

.github/workflows/lint.yml

@@ -17,7 +17,7 @@ on:
 jobs:
   golangci-lint:
     name: lint
-    runs-on: ubuntu-latest
+    runs-on: ["self-hosted"]
     env:
       GOPRIVATE: "github.com/dymensionxyz/*"
       GH_ACCESS_TOKEN: "${{ secrets.GH_ACCESS_TOKEN }}"

.github/workflows/markdownlint.yaml

@@ -8,7 +8,7 @@ on:
       - '**/*.md'
 jobs:
   markdownlint:
-    runs-on: ubuntu-latest
+    runs-on: ["self-hosted"]
     steps:
       - uses: actions/checkout@v3
       - name: markdownlint-cli

.github/workflows/release.yaml

@@ -8,7 +8,7 @@ on:
 jobs:
   release:
     name: release
-    runs-on: ubuntu-latest
+    runs-on: ["self-hosted"]
     permissions:
       pull-requests: write
       actions: read

.github/workflows/test.yml

@@ -16,7 +16,7 @@ on:
       - go.sum
 jobs:
   build:
-    runs-on: ["arm-linux"]
+    runs-on: ["self-hosted"]
     env:
       GOPRIVATE: "github.com/dymensionxyz/*"
       GH_ACCESS_TOKEN: "${{ secrets.GH_ACCESS_TOKEN }}"

.pre-commit-config.yaml

@@ -12,6 +12,9 @@ repos:
     rev: v1.59.1
     hooks:
       - id: golangci-lint
+        name: lint Go files
+        args: [--new-from-rev=HEAD, -v, --fix, --exclude-use-default, --sort-results]
+        files: \.go$
   - repo: https://github.com/compilerla/conventional-pre-commit
     rev: v3.2.0
     hooks:

cmd/config/export/bech32.go

@@ -10,10 +10,12 @@ import (
 )
 
 func getBech32Prefix(rlpCfg config.RollappConfig) (string, error) {
-	rollappSeqAddrInfo, err := utils.GetAddressBinary(utils.KeyConfig{
-		Dir: filepath.Join(rlpCfg.Home, consts.ConfigDirName.Rollapp),
-		ID:  consts.KeysIds.RollappSequencer,
-	}, rlpCfg.RollappBinary)
+	rollappSeqAddrInfo, err := utils.GetAddressInfoBinary(
+		utils.KeyConfig{
+			Dir: filepath.Join(rlpCfg.Home, consts.ConfigDirName.Rollapp),
+			ID:  consts.KeysIds.RollappSequencer,
+		}, rlpCfg.RollappBinary,
+	)
 	if err != nil {
 		return "", err
 	}

cmd/config/export/export.go

@@ -20,7 +20,7 @@ func Cmd() *cobra.Command {
 		Short: "Export the rollapp configurations jsons needed to list your rollapp.",
 		Run: func(cmd *cobra.Command, args []string) {
 			home := cmd.Flag(utils.FlagNames.Home).Value.String()
-			rlpCfg, err := config.LoadConfigFromTOML(home)
+			rlpCfg, err := config.LoadRollerConfigFromTOML(home)
 			utils.PrettifyErrorIfExists(err)
 			bech32, err := getBech32Prefix(rlpCfg)
 			utils.PrettifyErrorIfExists(err)
@@ -38,8 +38,12 @@ func Cmd() *cobra.Command {
 			rly := relayer.NewRelayer(rlpCfg.Home, rlpCfg.RollappID, rlpCfg.HubData.ID)
 			_, _, err = rly.LoadActiveChannel()
 			if err != nil || rly.SrcChannel == "" || rly.DstChannel == "" {
-				utils.PrettifyErrorIfExists(errors.New("failed to export rollapp json." +
-					" Please verify that the rollapp is running on your local machine and a relayer channel has been established"))
+				utils.PrettifyErrorIfExists(
+					errors.New(
+						"failed to export rollapp json." +
+							" Please verify that the rollapp is running on your local machine and a relayer channel has been established",
+					),
+				)
 			}
 			logoDefaultPath := fmt.Sprintf("/logos/%s.png", rlpCfg.RollappID)
 			networkJson := NetworkJson{

cmd/config/init/denom_metadata.go

@@ -1,9 +1,7 @@
 package initconfig
 
 import (
-	"encoding/json"
 	"fmt"
-	"os"
 	"strings"
 )
 
@@ -48,22 +46,3 @@ func getBankDenomMetadata(denom string, decimals uint) []BankDenomMetadata {
 	}
 	return metadata
 }
-
-func createTokenMetadaJSON(metadataPath string, denom string, decimals uint) error {
-	metadata := getBankDenomMetadata(denom, decimals)
-	json, err := json.Marshal(metadata)
-	if err != nil {
-		return err
-	}
-
-	file, err := os.Create(metadataPath)
-	if err != nil {
-		return err
-	}
-	_, err = file.WriteString(string(json))
-	if err != nil {
-		return err
-	}
-
-	return nil
-}

cmd/config/init/genesis.go

@@ -14,9 +14,9 @@ import (
 	"github.com/dymensionxyz/roller/config"
 )
 
-const (
-	totalSupplyToStakingRatio = 2
-)
+// const (
+// 	totalSupplyToStakingRatio = 2
+// )
 
 type PathValue struct {
 	Path  string
@@ -67,7 +67,7 @@ func UpdateJSONParams(jsonFilePath string, params []PathValue) error {
 	}
 
 	// nolint:gofumpt
-	err = os.WriteFile(jsonFilePath, []byte(jsonFileContentString), 0644)
+	err = os.WriteFile(jsonFilePath, []byte(jsonFileContentString), 0o644)
 	if err != nil {
 		return err
 	}
@@ -79,12 +79,12 @@ func UpdateGenesisParams(home string, raCfg *config.RollappConfig) error {
 	if err != nil {
 		return err
 	}
-	cfg, err := config.LoadConfigFromTOML(home)
+	cfg, err := config.LoadRollerConfigFromTOML(home)
 	if err != nil {
 		return err
 	}
 
-	sa, err := getSequencerAddress(home)
+	sa, err := GetRollappSequencerAddress(home)
 	if err != nil {
 		return err
 	}
@@ -153,28 +153,20 @@ func getGenesisOperatorAddress(home string) (string, error) {
 	return a, nil
 }
 
-func getSequencerAddress(home string) (string, error) {
+func GetRollappSequencerAddress(home string) (string, error) {
 	rollappConfigDirPath := filepath.Join(home, consts.ConfigDirName.Rollapp)
-	getOperatorAddrCommand := exec.Command(
-		consts.Executables.RollappEVM,
-		"keys",
-		"show",
-		consts.KeysIds.RollappSequencer,
-		"-a",
-		"--keyring-backend",
-		"test",
-		"--home",
-		rollappConfigDirPath,
-	)
-
-	addr, err := utils.ExecBashCommandWithStdout(getOperatorAddrCommand)
+	seqKeyConfig := utils.KeyConfig{
+		Dir:         rollappConfigDirPath,
+		ID:          consts.KeysIds.RollappSequencer,
+		ChainBinary: consts.Executables.RollappEVM,
+		Type:        config.EVM_ROLLAPP,
+	}
+	addr, err := utils.GetAddressBinary(seqKeyConfig, seqKeyConfig.Dir)
 	if err != nil {
-		fmt.Println("seq addr failed")
 		return "", err
 	}
 
-	a := strings.TrimSpace(addr.String())
-	return a, nil
+	return addr, nil
 }
 
 // func generateGenesisTx(initConfig config.RollappConfig) error {

cmd/config/init/keys.go

@@ -96,7 +96,6 @@ func CreateAddressBinary(
 		"--output", "json",
 	}
 	createKeyCommand := exec.Command(keyConfig.ChainBinary, args...)
-	fmt.Println(createKeyCommand.String())
 	out, err := utils.ExecBashCommandWithStdout(createKeyCommand)
 	if err != nil {
 		return nil, err

cmd/config/init/unique_rollapp_id.go

@@ -1,14 +1,5 @@
 package initconfig
 
-import (
-	"encoding/json"
-	"os/exec"
-
-	"github.com/dymensionxyz/roller/cmd/consts"
-	"github.com/dymensionxyz/roller/cmd/utils"
-	"github.com/dymensionxyz/roller/config"
-)
-
 type Rollapp struct {
 	ID string `json:"rollappId"`
 }
@@ -17,25 +8,25 @@ type RollappsListResponse struct {
 	Rollapps []Rollapp `json:"rollapp"`
 }
 
-func isEthIdentifierUnique(ethID string, rlpCfg config.RollappConfig) (bool, error) {
-	commonDymdFlags := utils.GetCommonDymdFlags(rlpCfg)
-	// TODO: Move the filtering by ethereum rollapp ID logic to the hub
-	args := []string{"q", "rollapp", "list", "--limit", "1000000"}
-	args = append(args, commonDymdFlags...)
-	listRollappCmd := exec.Command(consts.Executables.Dymension, args...)
-	out, err := utils.ExecBashCommandWithStdout(listRollappCmd)
-	if err != nil {
-		return false, err
-	}
-	rollappsListResponse := RollappsListResponse{}
-	err = json.Unmarshal(out.Bytes(), &rollappsListResponse)
-	if err != nil {
-		return false, err
-	}
-	for _, rollapp := range rollappsListResponse.Rollapps {
-		if config.GetEthID(rollapp.ID) == ethID {
-			return false, nil
-		}
-	}
-	return true, nil
-}
+// func isEthIdentifierUnique(ethID string, rlpCfg config.RollappConfig) (bool, error) {
+// 	commonDymdFlags := utils.GetCommonDymdFlags(rlpCfg)
+// 	// TODO: Move the filtering by ethereum rollapp ID logic to the hub
+// 	args := []string{"q", "rollapp", "list", "--limit", "1000000"}
+// 	args = append(args, commonDymdFlags...)
+// 	listRollappCmd := exec.Command(consts.Executables.Dymension, args...)
+// 	out, err := utils.ExecBashCommandWithStdout(listRollappCmd)
+// 	if err != nil {
+// 		return false, err
+// 	}
+// 	rollappsListResponse := RollappsListResponse{}
+// 	err = json.Unmarshal(out.Bytes(), &rollappsListResponse)
+// 	if err != nil {
+// 		return false, err
+// 	}
+// 	for _, rollapp := range rollappsListResponse.Rollapps {
+// 		if config.GetEthID(rollapp.ID) == ethID {
+// 			return false, nil
+// 		}
+// 	}
+// 	return true, nil
+// }

cmd/config/set/da.go

@@ -10,7 +10,7 @@ import (
 	"github.com/dymensionxyz/roller/config"
 	datalayer "github.com/dymensionxyz/roller/data_layer"
 	"github.com/dymensionxyz/roller/sequencer"
-	global_utils "github.com/dymensionxyz/roller/utils"
+	globalutils "github.com/dymensionxyz/roller/utils"
 )
 
 func setDA(rlpCfg config.RollappConfig, value string) error {
@@ -27,10 +27,11 @@ func setDA(rlpCfg config.RollappConfig, value string) error {
 
 func updateDaConfig(rlpCfg config.RollappConfig, newDa config.DAType) error {
 	daCfgDirPath := filepath.Join(rlpCfg.Home, consts.ConfigDirName.DALightNode)
-	dirExist, err := global_utils.DirNotEmpty(daCfgDirPath)
+	dirExist, err := globalutils.DirNotEmpty(daCfgDirPath)
 	if err != nil {
 		return err
 	}
+
 	if dirExist {
 		if yes, err := utils.PromptBool("Changing DA will remove the old DA keys permanently. Are you sure you want to proceed"); err != nil {
 			return err
@@ -41,18 +42,22 @@ func updateDaConfig(rlpCfg config.RollappConfig, newDa config.DAType) error {
 	if err := os.RemoveAll(daCfgDirPath); err != nil {
 		return err
 	}
+
 	daManager := datalayer.NewDAManager(newDa, rlpCfg.Home)
 	_, err = daManager.InitializeLightNodeConfig()
 	if err != nil {
 		return err
 	}
+
 	rlpCfg.DA = newDa
 	if err := sequencer.UpdateDymintDAConfig(rlpCfg); err != nil {
 		return err
 	}
+
 	if err := config.WriteConfigToTOML(rlpCfg); err != nil {
 		return err
 	}
+
 	fmt.Printf("💈 RollApp DA has been successfully set to '%s'\n\n", newDa)
 	if newDa != config.Local {
 		addresses := make([]utils.KeyInfo, 0)
@@ -61,10 +66,12 @@ func updateDaConfig(rlpCfg config.RollappConfig, newDa config.DAType) error {
 		if err != nil {
 			return err
 		}
-		addresses = append(addresses, utils.KeyInfo{
-			Name:    damanager.GetKeyName(),
-			Address: daAddress.Address,
-		})
+		addresses = append(
+			addresses, utils.KeyInfo{
+				Name:    damanager.GetKeyName(),
+				Address: daAddress.Address,
+			},
+		)
 
 		utils.PrintAddressesWithTitle(addresses)
 		fmt.Printf("\n🔔 Please fund this address to run the DA light client.\n")

cmd/config/set/set.go

@@ -4,9 +4,10 @@ import (
 	"fmt"
 	"strings"
 
+	"github.com/spf13/cobra"
+
 	"github.com/dymensionxyz/roller/cmd/utils"
 	"github.com/dymensionxyz/roller/config"
-	"github.com/spf13/cobra"
 )
 
 var keyUpdateFuncs = map[string]func(cfg config.RollappConfig, value string) error{
@@ -31,7 +32,7 @@ func Cmd() *cobra.Command {
 		Args: cobra.ExactArgs(2),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			home := cmd.Flag(utils.FlagNames.Home).Value.String()
-			rlpCfg, err := config.LoadConfigFromTOML(home)
+			rlpCfg, err := config.LoadRollerConfigFromTOML(home)
 			if err != nil {
 				return err
 			}

cmd/consts/consts.go

@@ -39,12 +39,14 @@ var KeysIds = struct {
 	RollappSequencer string
 	RollappRelayer   string
 	HubRelayer       string
+	Celestia         string
 }{
 	HubSequencer:     "hub_sequencer",
 	HubGenesis:       "hub_genesis",
 	RollappSequencer: "rollapp_genesis_account",
 	RollappRelayer:   "relayer-rollapp-key",
 	HubRelayer:       "relayer-hub-key",
+	Celestia:         "my_celes_key",
 }
 
 var AddressPrefixes = struct {
@@ -115,7 +117,6 @@ var LocalHubData = config.HubData{
 	RPC_URL:         "http://localhost:36657",
 	ARCHIVE_RPC_URL: "http://localhost:36657",
 	GAS_PRICE:       "100000000",
-	SEQ_MIN_BOND:    "100dym",
 }
 
 var MockHubData = config.HubData{
@@ -124,7 +125,6 @@ var MockHubData = config.HubData{
 	RPC_URL:         "",
 	ARCHIVE_RPC_URL: "",
 	GAS_PRICE:       "",
-	SEQ_MIN_BOND:    "",
 }
 
 // TODO(#112): The available hub networks should be read from YAML file