Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prune): fix guard for sequencer #966

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(prune): fix guard for sequencer #966

merged 1 commit into from
Jul 19, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Jul 18, 2024 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #956

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner July 18, 2024 10:44
@danwt
Copy link
Contributor Author

danwt commented Jul 18, 2024

Please check me carefully here

@omritoptix omritoptix merged commit 9fa4109 into main Jul 19, 2024
7 checks passed
@omritoptix omritoptix deleted the danwt/956-fix-prune-guard-if-statement branch July 19, 2024 10:41
@mtsitrin mtsitrin restored the danwt/956-fix-prune-guard-if-statement branch August 5, 2024 09:37
@mtsitrin mtsitrin mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zale144 zale144 zale144 approved these changes

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix prune guard
3 participants
@danwt @omritoptix @zale144