Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): adds missing error log #965

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix(sync): adds missing error log #965

merged 2 commits into from
Jul 19, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Jul 18, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #955

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner July 18, 2024 10:38
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.96%. Comparing base (5a3478b) to head (f9db178).
Report is 7 commits behind head on main.

Files Patch % Lines
block/retriever.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   39.25%   33.96%   -5.29%     
==========================================
  Files         121      126       +5     
  Lines       18420    21274    +2854     
==========================================
- Hits         7230     7225       -5     
- Misses      10149    13012    +2863     
+ Partials     1041     1037       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

keruch
keruch previously approved these changes Jul 19, 2024
block/retriever.go Outdated Show resolved Hide resolved
@omritoptix omritoptix merged commit 9da82f1 into main Jul 19, 2024
6 checks passed
@omritoptix omritoptix deleted the danwt/955-log-error branch July 19, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log error in syncToTargetHeight
4 participants