feat(blockmanager): removed namespace from blockmanager #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
changed the title
mtsitrin
commented
Jul 10, 2024
|
|
||
| // NewStateFromGenesis reads blockchain State from genesis. | ||
| // The active sequencer list will be set on InitChain | ||
| func NewStateFromGenesis(genDoc *tmtypes.GenesisDoc) (*types.State, error) { |
There was a problem hiding this comment.
moved from types/state.go
mtsitrin
commented
Jul 10, 2024
| @@ -216,35 +206,6 @@ func NewNode( | |||
| return node, nil | |||
| } | |||
|
|
|||
| // initGenesisChunks creates a chunked format of the genesis document to make it easier to | |||
| // iterate through larger genesis structures. | |||
| func (n *Node) initGenesisChunks() error { | |||
There was a problem hiding this comment.
moved to rpc package
danwt
reviewed
Jul 12, 2024
danwt
previously approved these changes
Jul 12, 2024
rpc/client/utils.go
Outdated
Comment on lines
44
to
46
| if end > len(data) { | ||
| end = len(data) | ||
| } |
mtsitrin
deleted the
mtsitrin/806-namespaceid-as-a-block-field-is-probably-redundent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #XXX
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: