fix(manager): resume block production right when skew < max skew #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omritoptix
changed the title
omritoptix
reviewed
Nov 22, 2024
block/produce.go
Outdated
| @@ -82,7 +82,7 @@ func (m *Manager) ProduceBlockLoop(ctx context.Context, bytesProducedC chan int) | |||
| return nil | |||
| case bytesProducedC <- bytesProducedN: | |||
| default: | |||
| evt := &events.DataHealthStatus{Error: fmt.Errorf("bytes produced channel is full: %w", gerrc.ErrResourceExhausted)} | |||
| evt := &events.DataHealthStatus{Error: fmt.Errorf("Block production paused. Time between last block produced and last block submitted higher than max skew time %s: %w", m.Conf.MaxSkewTime, gerrc.ErrResourceExhausted)} | |||
There was a problem hiding this comment.
probably worth also putting here the last block subimtted time
omritoptix
reviewed
Nov 22, 2024
block/submit.go
Outdated
Comment on lines
113
to
114
| pendingBytes.Store(pending) | ||
| ticker.Reset(maxBatchSubmitTime) |
There was a problem hiding this comment.
I don't understand this. can you please explain? thanks
There was a problem hiding this comment.
moved after loop and documented.
mtsitrin
reviewed
Nov 25, 2024
| pending = uint64(unsubmittedBlocksBytes()) //nolint:gosec // bytes size is always positive | ||
| logger.Info("Submitted a batch to both sub-layers.", "n bytes consumed from pending", nConsumed, "pending after", pending) // TODO: debug level | ||
| pending = uint64(unsubmittedBlocksBytes()) //nolint:gosec // bytes size is always positive | ||
| if batchSkewTime() < maxSkewTime { |
There was a problem hiding this comment.
can u elaborate on the use of this if?
why not call trigger.Nudge() after submission loop finished as before?
There was a problem hiding this comment.
if it is called after the loop, the block production wont be restarted until all pending batches, that have been created before stopping block production, are submitted to SL. this way block production will be restarted after the skew time condition is met without having to wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #XXX
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: