Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get revision for height instead of the latest #1238

Closed
wants to merge 106 commits into from

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Nov 18, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@keruch keruch requested a review from srene November 18, 2024 16:21
@keruch keruch self-assigned this Nov 18, 2024
@keruch keruch requested a review from a team as a code owner November 18, 2024 16:21
mtsitrin
mtsitrin previously approved these changes Nov 19, 2024
Base automatically changed from srene/hardfork-fix to main November 19, 2024 10:06
@mtsitrin mtsitrin dismissed their stale review November 19, 2024 10:06

The base branch was changed.

@keruch
Copy link
Contributor Author

keruch commented Nov 20, 2024

closed due to conflicts, reopened a new PR instead #1249

@keruch keruch closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants