Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RDK proto dependencies #1230

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix: RDK proto dependencies #1230

merged 2 commits into from
Nov 14, 2024

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Nov 13, 2024

PR Standards

We need the same proto msg in both Dymint and RDK repos. At the same time, Rollapp-EVM imports both Dymint and RDK, so potentially msg is initialized twice.

Solution Issue
Copy RDK proto to Dymint, same proto msg name Proto error: cannot have two implementations of one type
Copy RDK proto to Dymint, different proto msg name Cosmos Any error: cannot unpack one message to another since they are completely different (different name, different implementation)
Move RDK proto to proto-registry, use it in RDK and Dymint Need to add methods to messages. To make this work, the entire module (x/sequencers) needs to be moved to the shared repo
✅ Import RDK in Dymint Dependency cycle, but should be fine as long as we maintain the correct versioning

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@keruch keruch self-assigned this Nov 13, 2024
@keruch keruch requested a review from a team as a code owner November 13, 2024 18:04
@keruch keruch requested a review from omritoptix November 13, 2024 18:18
@danwt danwt merged commit 59179aa into main Nov 14, 2024
4 checks passed
@danwt danwt deleted the kirill/rdk-proto-fix branch November 14, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants