Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager): refactor freezing node using context #1227

Closed
wants to merge 4 commits into from

Conversation

srene
Copy link
Contributor

@srene srene commented Nov 12, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1216

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this Nov 12, 2024
@srene srene requested a review from a team as a code owner November 12, 2024 16:40
@srene srene marked this pull request as draft November 12, 2024 16:51
@srene srene changed the title fix(manager): exit loops when node is frozen fix(manager): refactor freezing node using context Nov 12, 2024
@srene srene marked this pull request as ready for review November 12, 2024 20:59
Comment on lines 273 to 274
n.cancel()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question arises, why was this commented out in the first place?

@srene srene marked this pull request as draft November 14, 2024 20:54
@srene
Copy link
Contributor Author

srene commented Nov 18, 2024

closing it since its already included in #1212

@srene srene closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unsubscribe doesnt work when testing P2P and use mock DA
2 participants