Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): fix websocket subscription panic when no closing error #1046

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Aug 27, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

In case RPC websocket is closed with an error that is not websocket.CloseError, UnsubscribeAll is not called. This causes the service may try to write to a closed channel, when the error happens and the websocket is closed.

This PR basically calls UnsubscribeAll when any error

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1043

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner August 27, 2024 15:12
@srene srene self-assigned this Aug 27, 2024
@omritoptix omritoptix merged commit 6bf24d0 into main Aug 27, 2024
7 checks passed
@omritoptix omritoptix deleted the srene/1043-rpc-subscribe-fix branch August 27, 2024 16:54
@srene srene restored the srene/1043-rpc-subscribe-fix branch August 28, 2024 10:27
omritoptix pushed a commit that referenced this pull request Aug 28, 2024
omritoptix pushed a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suspected panic when error in closing websocket
2 participants