Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager): applylocalblock change mutex #1036

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Aug 22, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1033

This PR fixes a bug that causes the retrieve mutex is not unlocked if it fails to apply local block stored in db, which will happen in case the block is already applied between the time the block is loaded from db and its applied.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner August 22, 2024 16:24
omritoptix
omritoptix previously approved these changes Aug 24, 2024
@omritoptix
Copy link
Contributor

@srene build failed. data race.

@omritoptix omritoptix dismissed their stale review August 24, 2024 09:15

deadlock

@srene
Copy link
Contributor Author

srene commented Aug 26, 2024

@srene build failed. data race.

not sure where is the race condition. tests run fine now without any modification. i think the flaky test is not related to this pr.

@omritoptix omritoptix merged commit fe0f3cb into main Aug 27, 2024
7 checks passed
@omritoptix omritoptix deleted the srene/1033-applylocalblock-fix branch August 27, 2024 14:12
omritoptix pushed a commit that referenced this pull request Aug 28, 2024
omritoptix pushed a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong mutex in applylocalblock
2 participants