Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): improve blocksync logs #1030

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

srene
Copy link
Contributor

@srene srene commented Aug 21, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1029

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner August 21, 2024 08:58
@srene srene marked this pull request as draft August 21, 2024 09:45
@srene srene marked this pull request as ready for review August 21, 2024 15:12
@omritoptix omritoptix merged commit 25c069c into main Aug 21, 2024
7 checks passed
@omritoptix omritoptix deleted the srene/1029-improve-blocksync-logs branch August 21, 2024 16:47
omritoptix pushed a commit that referenced this pull request Aug 28, 2024
omritoptix pushed a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve blocksync logs
2 participants