-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(da): submitted batch size metric #1020
Conversation
WalkthroughThe changes enhance logging and monitoring in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
block/submit.go (1)
156-157
: Enhanced logging with batch size information.The log message now includes the batch size, providing better insight into batch creation. Ensure this level of detail is appropriate for the current logging level.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- block/submit.go (1 hunks)
- types/metrics.go (1 hunks)
Additional comments not posted (2)
types/metrics.go (1)
38-41
: LGTM! New metric added for batch size tracking.The addition of
LastBatchSubmittedBytes
enhances observability by tracking the size of the last submitted batch. The metadata is appropriately defined.block/submit.go (1)
157-157
: Metric update for batch size tracking.The
LastBatchSubmittedBytes
metric is updated with the batch size, enhancing monitoring capabilities.
(cherry picked from commit fd3cf3c)
(cherry picked from commit fd3cf3c)
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #1007
<-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation