Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fraud): refunding pending outgoing packets #816

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Apr 8, 2024

covering few scenarios:

  • hub -> Rollapp: delayed acknowledgement reverted
  • hub -> Rollapp: delayed timeout reverted

for both cases, refund needed.

regarding the rollapp->hub (delayed onRecv), no need to handle it, as the original packet commitment won't be present on the forked rollapp

Description


Closes #811

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin marked this pull request as ready for review April 8, 2024 20:01
@mtsitrin mtsitrin requested a review from a team as a code owner April 8, 2024 20:01
srene
srene previously approved these changes Apr 8, 2024
@omritoptix omritoptix changed the title fix: refunding pending outgoing packets fix(fraud): refunding pending outgoing packets Apr 8, 2024
@omritoptix omritoptix merged commit 456e6aa into main Apr 8, 2024
4 checks passed
@omritoptix omritoptix deleted the mtsitrin/811-fraud-handling-doesnt-credit-timeout-and-ackerr-packets-initiated-on-the-hub branch April 8, 2024 21:38
omritoptix added a commit that referenced this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fraud handling doesn't credit timeout and ackErr packets initiated on the hub
3 participants