Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): add upgrade handler for new and modified modules #783

Merged

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Apr 1, 2024

Description


Closes #572

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner April 1, 2024 16:44
@mtsitrin mtsitrin linked an issue Apr 1, 2024 that may be closed by this pull request
4 tasks
@mtsitrin mtsitrin requested a review from omritoptix April 1, 2024 16:44
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 29.59%. Comparing base (19a588c) to head (dbef7e7).
Report is 11 commits behind head on main.

Files Patch % Lines
cmd/dymd/cmd/inspect_tendermint.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   31.49%   29.59%   -1.91%     
==========================================
  Files         233      234       +1     
  Lines       32640    32689      +49     
==========================================
- Hits        10281     9675     -606     
- Misses      20740    21537     +797     
+ Partials     1619     1477     -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zale144
zale144 previously approved these changes Apr 1, 2024
app/apptesting/test_helpers.go Show resolved Hide resolved
app/upgrades/v3/upgrade.go Outdated Show resolved Hide resolved
@omritoptix omritoptix merged commit 1a1da34 into main Apr 2, 2024
25 of 26 checks passed
@omritoptix omritoptix deleted the mtsitrin/572-add-upgrade-handler-for-new-and-modified-modules branch April 2, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add upgrade handler for new and modified modules
5 participants