Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollapp): genesisState of rollapp is non-nullable struct #742

Merged

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Mar 27, 2024

Description

setting RollappGenesisState as non nullable object, as it's always required.
the repeated GenesisAccount is nullable


Closes #740

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner March 27, 2024 14:28
@mtsitrin mtsitrin linked an issue Mar 27, 2024 that may be closed by this pull request
zale144
zale144 previously approved these changes Mar 27, 2024
Copy link
Contributor

@zale144 zale144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mtsitrin mtsitrin self-assigned this Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 31.20%. Comparing base (bc7ad7f) to head (99598ad).

Files Patch % Lines
x/rollapp/types/rollapp.pb.go 64.28% 4 Missing and 1 partial ⚠️
x/rollapp/types/tx.pb.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   31.23%   31.20%   -0.03%     
==========================================
  Files         233      233              
  Lines       32593    32582      -11     
==========================================
- Hits        10179    10167      -12     
  Misses      20782    20782              
- Partials     1632     1633       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin merged commit 13b381d into main Mar 27, 2024
17 of 26 checks passed
@mtsitrin mtsitrin deleted the 740-empty-rollapp-genesis-state-breaks-the-genesis-event branch March 27, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty rollapp genesis state breaks the genesis event
2 participants